Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

added gender tag #104

Merged
merged 2 commits into from
Jun 7, 2020
Merged

added gender tag #104

merged 2 commits into from
Jun 7, 2020

Conversation

musinit
Copy link
Contributor

@musinit musinit commented Jun 7, 2020

No description provided.

@musinit musinit mentioned this pull request Jun 7, 2020
@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #104 into master will decrease coverage by 0.44%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   94.75%   94.30%   -0.45%     
==========================================
  Files          10       10              
  Lines        1010     1019       +9     
==========================================
+ Hits          957      961       +4     
- Misses         29       34       +5     
  Partials       24       24              
Impacted Files Coverage Δ
faker.go 90.42% <ø> (ø)
person.go 93.90% <44.44%> (-6.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67194d...90486ea. Read the comment docs.

@@ -108,6 +109,8 @@ var lastNames = []string{
}
var randNameFlag = rand.Intn(100)

var genders = []string{"Male", "Female", "Prefer to skip"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3rd option might need to revise later.

But it's okay for now.

@bxcodec bxcodec merged commit a395211 into bxcodec:master Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants