This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Float boundaries #156
Merged
Float boundaries #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added ability to set boundaries for float32 and float64 types * rename old methods which supports only integers to more explicit * update tests * delete test which checks float to unsupported struct to boundaries
|
Hey, @Xaspy thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @bxcodec.
I have no idea why float32 and float64 isn't support boundaries tags. This is why I made this PR.
What is reason of that this isn't made before? I want to discuss it cause I can don't realize some fatal reasons of this. Please, take a look.
What made by me: