This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
feat: Add skipping field tag #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 97.84% 97.86% +0.01%
==========================================
Files 8 8
Lines 372 375 +3
==========================================
+ Hits 364 367 +3
Misses 4 4
Partials 4 4
Continue to review full report at Codecov.
|
bxcodec
suggested changes
Aug 23, 2018
faker.go
Outdated
| val, err := getValue(v.Field(i).Type()) | ||
| if err != nil { | ||
| return reflect.Value{}, err | ||
| } | ||
| val = val.Convert(v.Field(i).Type()) | ||
| v.Field(i).Set(val) | ||
| } else { | ||
| case "skip": |
There was a problem hiding this comment.
thank you for the PR.
We forgot to add this.
IMHO, I think it's better to use dash (-) instead of skip like what JSON tag's do if we want to ignore some field.
type Sample struct {
ID string `json:"-"`
}There was a problem hiding this comment.
Good idea. :) smaller and simpler. Done.
Closed
|
Hi @bxcodec , this is insufficient when working with generated code (with generated struct tags). Could you add a method to ignore fields instead? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Thank you for good library. But I don't see ability to skip some fields for faking data. This PR should be fix it.