This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
feat: UUID Generator #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a UUID to the faker. It is possible to create a 32 bit UUID with chars and a 36 bit UUID with hyphenates.
Added ID and HyphenatedID with correct functions. Changed correct return type: error => string and correct input to match userdefinedstrings method. Use of panic if createUUID fails, perhaps this is an overkill. Could be changed to just return 'nil'. Updated test case to match correction in uuid.go
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 98.02% 98.12% +0.09%
==========================================
Files 9 10 +1
Lines 406 426 +20
==========================================
+ Hits 398 418 +20
Misses 4 4
Partials 4 4
Continue to review full report at Codecov.
|
Closed
|
Looks like a feature more than one is looking for, i think it would be fair to close issue #39 after merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Identifier for faker.
Usage:
faker:"uuid_digit"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxfaker:"uuid_hyphenated"xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxxclose #39