This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
feat: add card type of jcb and diners club #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
======================================
Coverage 93.7% 93.7%
======================================
Files 10 10
Lines 556 556
======================================
Hits 521 521
Misses 18 18
Partials 17 17
Continue to review full report at Codecov.
|
bxcodec
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Hi @revenue-hack
Thanks for the PR. Really appreciate that.
Everything looks good to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that I wanted to increase the credit card type and added the famous credit cards of JCB and Diners Club.