Issue #162 - New Location Type Converter #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uthadehikaru
suggested changes
Mar 28, 2024
|
|
||
| JsonElement regionField = ref.get(MLocation.COLUMNNAME_C_Region_ID.toLowerCase()); | ||
| int C_Region_ID = 0; | ||
| if (countryField != null) { |
There was a problem hiding this comment.
it's must be regionField instead countryField.
for the column name, i think it's not needed to lower case cause it make not consistent with default converter
CarlosRuiz-globalqss
approved these changes
Mar 28, 2024
CarlosRuiz-globalqss
pushed a commit
that referenced
this pull request
Apr 29, 2024
CarlosRuiz-globalqss
pushed a commit
to CarlosRuiz-globalqss/idempiere-rest
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.