forked from PurpleBananass/Invaders
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor : re engineering #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/bgm selection
TeamHUD: fix alignment of item font
fix: bgm sound bug
기존의 Space Invador 프로젝트를 포팅 중. 현재 Login,Menu,Setting,Store 스크린을 작업 완료 하였으며 앞으로 Game,achieve 스크린을 작업할 예정 추가적으로 리소스의 Raw한 도트 파일 사용을 중단하고 Png파일로 대체 하는 작업을 거치는 중.
이후 UI 및 사운드 개선이 요구됨
bysxx
reviewed
Nov 12, 2023
@@ -0,0 +1,18 @@ | |||
package EnginePrime; | |||
|
|||
public interface GManager { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IManager 이런 네이밍이 조금 더 좋아보이네요
|
||
public void PreUpdate(); | ||
|
||
public void LateUpdate(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre, Late -> before, after가 조금 더 명확할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed a code refactoring, and there are a few changes:
I abandoned dot graphics and switched to image resources.
I changed the skill mode to a hard mode, limiting the magazine.
Save files will now be in JSON format.
There are 3 test Levels.