This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Fix mssql check_if_admin function #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check_if_admin function from mssql.py takes an additional auth parameter, that is actually not used. Other parts of the code are calling the function without the parameter, which leads to an error when enumerating mssql endpoints. By simply removing the parameter and fixing the locations that use it, the issue gets resolved.
|
Indeed really strange :) |
|
There's more to this, I reverted just that commit, built 5.30, and it fails again. |
|
So maybe it is not linked to this commit at all 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check_if_admin function from
mssql.pytakes an additionalauthparameter, that is actually not used. Other parts of the code are calling the function without the parameter, which leads to an error when enumerating mssql endpoints. By simply removing the parameter and fixing the locations that use it, the issue gets resolved.The actual bug is currently sitting at line 216. This line calls the
check_if_adminfunction with no parameters, despite the current version requires one.