This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Update nanodump.py #564
Closed
Update nanodump.py #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix for logfile name collision found in the wild
|
hello, thanks for the pr, can you explain a bit more ? |
|
Haha yes sorry for the ambiguity. I ran into a situation with this module where the regex grabbed the wrong file and downloaded it, instead of the right dump file. There were legitimate log files in the temp directory what had similar naming conventions. I made the small change in the PR to the dump file generation and it then worked. While it was an environment specific issue, thought it might be useful more broadly as well. It looked like the log files were generated from some kind of automated tool. |
Merged
|
We follow #578 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for logfile name collision found in the wild