Support plugins with imported functions #881
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the noise on this. For some reason, the test suite appears to be pass locally when I run it. |
|
Looks like all checks on GitHub Actions are passing now. |
saulecabrera
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates the linker configuration when generating QuickJS bytecode to stub out unknown imports with traps.
Also updates the test plugin to have an imported function and updates the test runner to also stub out unknown imports with traps when executing the test cases.
Why am I making this change?
Fixes #878.
Checklist
javy-cliandjavy-plugindo not require updating CHANGELOG files.