Misc. fixes.

src/backend/libc/fs/syscalls.rs

@@ -1778,6 +1778,7 @@ pub(crate) fn sendfile(
 
 /// Convert from a Linux `statx` value to rustix's `Stat`.
 #[cfg(all(linux_kernel, target_pointer_width = "32"))]
+#[allow(deprecated)] // for `st_[amc]time` u64->i64 transition
 fn statx_to_stat(x: crate::fs::Statx) -> io::Result<Stat> {
     Ok(Stat {
         st_dev: crate::fs::makedev(x.stx_dev_major, x.stx_dev_minor).into(),
@@ -1828,6 +1829,7 @@ fn statx_to_stat(x: crate::fs::Statx) -> io::Result<Stat> {
 
 /// Convert from a Linux `stat64` value to rustix's `Stat`.
 #[cfg(all(linux_kernel, target_pointer_width = "32"))]
+#[allow(deprecated)] // for `st_[amc]time` u64->i64 transition
 fn stat64_to_stat(s64: c::stat64) -> io::Result<Stat> {
     Ok(Stat {
         st_dev: s64.st_dev.try_into().map_err(|_| io::Errno::OVERFLOW)?,

src/backend/linux_raw/fs/syscalls.rs

@@ -747,7 +747,6 @@ fn stat_to_stat(s64: linux_raw_sys::general::stat64) -> io::Result<Stat> {
         st_size: s64.st_size.try_into().map_err(|_| io::Errno::OVERFLOW)?,
         st_blksize: s64.st_blksize.try_into().map_err(|_| io::Errno::OVERFLOW)?,
         st_blocks: s64.st_blocks.try_into().map_err(|_| io::Errno::OVERFLOW)?,
-        // fixme
         st_atime: bitcast!(i64::from(s64.st_atime)),
         st_atime_nsec: s64
             .st_atime_nsec

src/fs/mod.rs

@@ -142,14 +142,15 @@ pub use std::os::unix::fs::{DirEntryExt, FileExt, FileTypeExt, MetadataExt, Open
 #[cfg(all(wasi_ext, target_os = "wasi"))]
 pub use std::os::wasi::fs::{DirEntryExt, FileExt, FileTypeExt, MetadataExt, OpenOptionsExt};
 
-/// Extension trait for accessing.
+/// Extension trait for accessing timestamp fields of `Stat`.
 ///
 /// Rustix's `Stat` type on some platforms has unsigned `st_mtime`,
 /// `st_atime`, and `st_ctime` fields. This is incorrect, as Unix defines
 /// these fields to be signed, with negative values representing dates before
 /// the Unix epoch. Until the next semver bump, these unsigned fields are
 /// deprecated, and this trait provides accessors which return their values
 /// as signed integers.
+#[cfg(unix)]
 pub trait StatExt {
     /// Return the value of the `st_atime` field, casted to the correct type.
     fn atime(&self) -> i64;
@@ -159,14 +160,18 @@ pub trait StatExt {
     fn ctime(&self) -> i64;
 }
 
+#[cfg(unix)]
 #[allow(deprecated)]
 impl StatExt for Stat {
+    #[inline]
     fn atime(&self) -> i64 {
         self.st_atime as i64
     }
+    #[inline]
     fn mtime(&self) -> i64 {
         self.st_mtime as i64
     }
+    #[inline]
     fn ctime(&self) -> i64 {
         self.st_ctime as i64
     }