Fix getsockopt zeroing memory #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an accidental regression from bytecodealliance#858 where a previous call to `core::mem::zeroed` was replaced with `MaybeUninit::uninit` instead of `MaybeUninit::zeroed`.
|
Thanks for tracking this down and fixing this! |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 26, 2023
github-merge-queue bot
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Oct 26, 2023
* Update some crates to align on latest `rustix` This commit addresses some dependabot warnings showing up on the Wasmtime repository by updating all dependencies to using the latest `rustix` release. * Debug CI prtest:full * Downgrade rustix to 0.38.14 Works around bytecodealliance/rustix#901
sunfishcode
added a commit
that referenced
this pull request
Oct 26, 2023
|
This is now released in rustix 0.38.21. |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 26, 2023
Completes the upgrade from bytecodealliance#7370 with bytecodealliance/rustix#901 being published to crates.io.
github-merge-queue bot
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Oct 26, 2023
Completes the upgrade from #7370 with bytecodealliance/rustix#901 being published to crates.io.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an accidental regression from #858 where a previous call to
core::mem::zeroedwas replaced withMaybeUninit::uninitinstead ofMaybeUninit::zeroed.