Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add io_uring_sqe64,io_uring_sqe128,io_uring_cqe16,io_uring_cqe32 #998

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2024

@sunfishcode
Copy link
Member

As the PR stands, this will require a major version bump, due to the change to io_uring_sqe.

@sunfishcode sunfishcode added the semver bump Issues that will require a semver-incompatible fix label Jan 19, 2024
@ghost
Copy link
Author

ghost commented Jan 19, 2024

There is no way to make the CI check successful because these structures do not exist in the kernel headers.

@ghost
Copy link
Author

ghost commented Jan 19, 2024

Alternatively, we can simply remove these zero-length fields, just like in the previous kernel.

pub type io_uring_sqe64 = io_uring_cqe<()>;

#[allow(missing_docs)]
pub type io_uring_sqe128 = io_uring_cqe<[u8; 80]>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub type io_uring_sqe128 = io_uring_cqe<[u8; 80]>;
pub type io_uring_sqe128 = io_uring_sqe<[u8; 80]>;

}

#[allow(missing_docs)]
pub type io_uring_sqe64 = io_uring_cqe<()>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub type io_uring_sqe64 = io_uring_cqe<()>;
pub type io_uring_sqe64 = io_uring_sqe<()>;

@ghost ghost closed this by deleting the head repository Feb 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver bump Issues that will require a semver-incompatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants