Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gecko-dev 124.0.2 with our patches #11

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

JakeChampion
Copy link
Contributor

@JakeChampion JakeChampion commented Apr 5, 2024

Our patches:

  • Bring back JS Streams
  • Add BYOB Streams
  • Re-add signal handling fix for WASI to fdlibm
  • JSAPI support for resetting the seed for Math.random()
  • Add JS::HasJobsPending
  • Respect js::ClassSpec::DontDefineConstructor in DefineConstructorAndPrototype
  • A bunch of Portable Baseline Interpreter updates which have landed in 125 but can be brought to 124

This work was done in https://github.com/bytecodealliance/gecko-dev/pull/41 and https://github.com/bytecodealliance/gecko-dev/pull/42

Our patches:
- Bring back JS Streams
- Add BYOB Streams
- Re-add signal handling fix for WASI to fdlibm 
- JSAPI support for resetting the seed for Math.random()
- Add JS::HasJobsPending
- Respect js::ClassSpec::DontDefineConstructor in DefineConstructorAndPrototype
- A bunch of Portable Baseline Interpreter updates which have landed in 125 but can be brought to 123

This work was done in bytecodealliance/gecko-dev#41 and bytecodealliance/gecko-dev#42
@JakeChampion
Copy link
Contributor Author

Note that this is the same commit that is used in Fastly's js-compute-runtime project, I'm hoping we can keep that project and StarlingMonkey always using the same gecko-dev commit

@JakeChampion JakeChampion changed the title Update to gecko-dev 123.0.1 with our patches Update to gecko-dev 124.0.2 with our patches Apr 12, 2024
@JakeChampion
Copy link
Contributor Author

@tschneidereit this is ready for review ✌️

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! <3

@tschneidereit tschneidereit merged commit 702095e into bytecodealliance:main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants