Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mutex stress test #2472

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add mutex stress test #2472

merged 1 commit into from
Aug 30, 2023

Conversation

Zzzabiyaka
Copy link
Contributor

@Zzzabiyaka Zzzabiyaka commented Aug 16, 2023 •
edited
Loading

as a part of stress-testing we want to ensure that mutex implementation is working correctly and protecting shared resource to be allocated from other threads when mutex is locked.

This test covers the most common situations that happen when some program uses mutexes like locks from various threads, locks from the same thread etc

If you have any other cases that left uncovered please mention them in the comments

cc @loganek @g0djan @eloparco

@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch 3 times, most recently from bd55f8d to c6d48bf Compare August 21, 2023 15:02
@Zzzabiyaka Zzzabiyaka changed the title [WIP] Add mutex stress test to WAMR Add mutex stress test to WAMR Aug 21, 2023
@Zzzabiyaka Zzzabiyaka marked this pull request as ready for review August 21, 2023 15:06
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch from c6d48bf to 506d2e5 Compare August 21, 2023 15:15
@Zzzabiyaka Zzzabiyaka changed the title Add mutex stress test to WAMR Add mutex stress test Aug 21, 2023
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch 7 times, most recently from 796603d to 9538d42 Compare August 21, 2023 21:03
@Zzzabiyaka Zzzabiyaka mentioned this pull request Aug 22, 2023
Closed
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch 2 times, most recently from 7edf4b2 to de50d6e Compare August 22, 2023 10:03
loganek
loganek requested changes Aug 22, 2023
View reviewed changes
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
core/iwasm/libraries/lib-wasi-threads/stress_test/mutex_common.h Outdated Show resolved Hide resolved
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch from de50d6e to f03f42c Compare August 22, 2023 19:32
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch 9 times, most recently from 248e53a to d78628c Compare August 24, 2023 09:59
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch from 7cfe87a to bc0bdf7 Compare August 24, 2023 12:20
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch 4 times, most recently from 3098b47 to 08adea1 Compare August 24, 2023 15:04
loganek
loganek approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@loganek loganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch 5 times, most recently from 4e4c64e to 9e13126 Compare August 29, 2023 13:12
@lum1n0us
Copy link
Collaborator

LGTM

@Zzzabiyaka Zzzabiyaka force-pushed the makslit/mutex_stress_test branch from 9e13126 to a108d58 Compare August 30, 2023 10:03
@wenyongh wenyongh merged commit 411b903 into bytecodealliance:main Aug 30, 2023
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@Zzzabiyaka
Add mutex stress test (bytecodealliance#2472)
fd04c64 
As a part of stress-testing we want to ensure that mutex implementation is working
correctly and protecting shared resource to be allocated from other threads when
mutex is locked.

This test covers the most common situations that happen when some program uses
mutexes like locks from various threads, locks from the same thread etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g0djan g0djan g0djan left review comments

@wenyongh wenyongh wenyongh left review comments

@loganek loganek loganek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zzzabiyaka @lum1n0us @loganek @wenyongh @g0djan