Remove duplicate API on Types
#1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the duplicate API of `Types` and `TypesRef` in the `wasmparser` crate by removing the API on `Types`. The source of truth is the one on `TypesRef` and maintaining this duplication is a bit of a burden as it's a lot of copy/pasted code. It's hoped that users can instead use `.as_ref()` "early on" which will enable the same usage as before. Ideally this would be a `Deref` impl but due to how `Deref` works that's not possible right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the duplicate API of
TypesandTypesRefin thewasmparsercrate by removing the API onTypes. The source of truth is the one onTypesRefand maintaining this duplication is a bit of a burden as it's a lot of copy/pasted code. It's hoped that users can instead use.as_ref()"early on" which will enable the same usage as before. Ideally this would be aDerefimpl but due to howDerefworks that's not possible right now.