wasmparser: Fix subtyping depth indexing #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report, the investigation, and a PR! I believe this is the right fix as well. Playing around with this locally this is a small test case to trigger the bug from before and this PR fixes it. If you'd like to include that here I'd be happy to flag this for merge: diff --git a/tests/local/component-model/gc.wast b/tests/local/component-model/gc.wast
index 1b409903f..d7a47456e 100644
--- a/tests/local/component-model/gc.wast
+++ b/tests/local/component-model/gc.wast
@@ -124,3 +124,12 @@
))
)
"sub type cannot have a final super type")
+
+(component
+ (type $t (resource (rep i32)))
+ (core func (canon resource.drop $t))
+ (core module
+ (type $t1 (sub (func)))
+ (type (sub $t1 (func)))
+ )
+) |
fix: bytecodealliance#1967 This patch addresses an issue in subtyping depth checking where `set_subtyping_depth` indexes the depth by `CoreTypeId`, but `get_subtyping_depth` accesses it using `CoreTypeId#index` (`u32`). This leads to "IndexMap: index out of bounds" error when validating WasmGC components with subtypes.
tanishiking
force-pushed
the
fix-subtype
branch
from
31192ae to
d017108
Compare
|
Thank you so much for taking a look & minimizing the reproduction @alexcrichton ! |
alexcrichton
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1967
This patch addresses an issue in subtyping depth checking where
set_subtyping_depthindexes the depth byCoreTypeId, butget_subtyping_depthaccesses it usingCoreTypeId#index(u32). This leads to "IndexMap: index out of bounds" error when validating WasmGC components with subtypes.