This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
Improve support for reftypes #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reftypes proposal adds a typed select operator to simplify type checking for reference types. The existing select operator is henceforth limited to operate on the original MVP types only. Spec change: WebAssembly/reference-types#43
|
Thank you for the patch! Are there are tests in https://github.com/WebAssembly/testsuite we can enable? |
Good question. It looks like most reference-types tests are currently passing. I tested out the ones still being skipped and found that two are now passing. I'll put up a PR for them. |
yurydelendik
pushed a commit
that referenced
this pull request
Jan 13, 2020
These tests are now passing, possibly because of #168.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a couple of recent changes to the reference types proposal that are required for CL/Spidermonkey.