Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithMultiMemory to Config. #66

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

peterhuene
Copy link
Member

This commit adds the WithMultiMemory method to Config to enable support for
the multi-memory feature.

Fixes #65.

This commit adds the `WithMultiMemory` method to `Config` to enable support for
the multi-memory feature.

Fixes #65.
@peterhuene peterhuene requested a review from fitzgen July 8, 2021 23:16
@peterhuene peterhuene merged commit 86af748 into bytecodealliance:main Jul 12, 2021
@peterhuene peterhuene deleted the fix-config branch July 12, 2021 16:34
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this review.

Was tests/Modules/MultiMemory.wat supposed to be an empty file?

Otherwise, looks great!

@peterhuene
Copy link
Member Author

Oh whoops, good eye. I'll remove that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WithMultiMemory to Config.
2 participants