install.sh: support compactified JSON from GitHub API. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Nov 2, 2023
|
I think CI may indicate that there's another version of the script which needs updating, the built version I presume |
In bytecodealliance/wasmtime#7377, we saw a case where a user gets compactified (single-line) JSON responses from the GitHub API. The `install.sh` logic to get the latest Wasmtime release version currently does text-munging that assumes a multiline (pretty-printed) JSON layout. This PR instead uses `tr` and `sed` to get the version number from either input format (thanks to @bjorn3 for the exact invocations!). Fixes bytecodealliance/wasmtime#7377.
cfallin
force-pushed
the
install-sh-compact-json
branch
from
778004a to
56bdb8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bytecodealliance/wasmtime#7377, we saw a case where a user gets compactified (single-line) JSON responses from the GitHub API. The
install.shlogic to get the latest Wasmtime release version currently does text-munging that assumes a multiline (pretty-printed) JSON layout. This PR instead usestrandsedto get the version number from either input format (thanks to @bjorn3 for the exact invocations!).Fixes bytecodealliance/wasmtime#7377.