review: perform UTF-8 check on GuestStr construction

bytecodealliance · Jan 3, 2023 · 4690bfb · 4690bfb
1 parent f0e2c6a
commit 4690bfb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/crates/wiggle/src/lib.rs b/crates/wiggle/src/lib.rs
@@ -746,7 +746,7 @@ impl<'a> GuestPtr<'a, str> {
     /// a [`GuestStrCow::Borrowed`] (a thin wrapper over [`GuestStr<'_, T>]`).
     pub fn as_cow(&self) -> Result<GuestStrCow<'a>, GuestError> {
         match self.as_bytes().as_unsafe_slice_mut()?.shared_borrow() {
-            UnsafeBorrowResult::Ok(s) => Ok(GuestStrCow::Borrowed(GuestStr(s))),
+            UnsafeBorrowResult::Ok(s) => Ok(GuestStrCow::Borrowed(s.try_into()?)),
             UnsafeBorrowResult::Shared(_) => {
                 let copied = self.as_bytes().to_vec()?;
                 let utf8_string = String::from_utf8(copied).map_err(|e| e.utf8_error())?;