Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift: doesn't compile in nightly because of staticvec #1877

Closed
pventuzelo opened this issue Jun 14, 2020 · 6 comments
Closed

Cranelift: doesn't compile in nightly because of staticvec #1877

pventuzelo opened this issue Jun 14, 2020 · 6 comments
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator

Comments

@pventuzelo
Copy link
Contributor

Build is broken using latest nightly due to staticvec. A new version of staticvec have been release.
see slightlyoutofphase/staticvec#37 for more info.

@pventuzelo pventuzelo added bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator labels Jun 14, 2020
@github-actions
Copy link

Subscribe to Label Action

cc @bnjbvr

This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

  • bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@bjorn3
Copy link
Contributor

bjorn3 commented Jun 14, 2020

Cranelift doesn't depend on staticvec, only Lightbeam does:

wasmtime/Cargo.lock

Lines 1102 to 1119 in 60d55a3

[[package]]
name = "lightbeam"
version = "0.18.0"
dependencies = [
"anyhow",
"capstone",
"cranelift-codegen",
"derive_more",
"dynasm",
"dynasmrt",
"iter-enum",
"itertools 0.8.2",
"lazy_static",
"memoffset",
"more-asserts",
"quickcheck",
"smallvec",
"staticvec",

@slightlyoutofphase
Copy link
Contributor

slightlyoutofphase commented Jun 14, 2020

I opened a pull request to update lightbeam's dependency to 0.10, which fixes this problem.

Sorry this has happened though... I honestly did not see it coming / expect it at all.

The "basic math operations in constant generic type signatures" language functionality I was using in 0.9 and earlier that got (intentionally it seems) broken / disabled had been working flawlessly for months, and to me seemed like an entirely "safe bet".

@pventuzelo
Copy link
Contributor Author

Thanks @slightlyoutofphase

@slightlyoutofphase
Copy link
Contributor

No problem!

@alexcrichton
Copy link
Member

I believe this has now been addressed, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

No branches or pull requests

4 participants