Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master doesn't build on macOS #30

Closed
pepyakin opened this issue Nov 29, 2018 · 2 comments
Closed

Master doesn't build on macOS #30

pepyakin opened this issue Nov 29, 2018 · 2 comments

Comments

@pepyakin
Copy link
Contributor

#27 doesn't build on macOS. It reports this error.

error: failed to run custom build command for `wasmtime-execute v0.0.0 (/Users/pepyakin/dev/etc/wasmtime/lib/execute)`
process didn't exit successfully: `/Users/pepyakin/dev/etc/wasmtime/target/debug/build/wasmtime-execute-60442602e4da687b/build-script-build` (exit code: 101)
--- stdout
running: "cmake" "/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers" "-DCMAKE_INSTALL_PREFIX=/Users/pepyakin/dev/etc/wasmtime/target/debug/build/wasmtime-execute-bf7593e5d6264f14/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_BUILD_TYPE=Debug"
-- The CXX compiler identification is AppleClang 9.0.0.9000039
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/pepyakin/dev/etc/wasmtime/target/debug/build/wasmtime-execute-bf7593e5d6264f14/out/build
running: "cmake" "--build" "." "--target" "install" "--config" "Debug" "--"
Scanning dependencies of target SignalHandlers
[ 50%] Building CXX object CMakeFiles/SignalHandlers.dir/SignalHandlers.cpp.o

--- stderr
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_C_COMPILER
    CMAKE_C_FLAGS


/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:332:40: error: unknown type name 'greg_t'
    PC_sig(context) = reinterpret_cast<greg_t>(pc);
                                       ^
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:332:48: error: assigning to '__uint64_t' (aka 'unsigned long long') from incompatible type 'const uint8_t *' (aka 'const unsigned char *')
    PC_sig(context) = reinterpret_cast<greg_t>(pc);
                                               ^~
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:523:9: error: unknown type name 'AutoNoteSingleThreadedRegion'
        AutoNoteSingleThreadedRegion anstr;
        ^
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:747:13: error: use of undeclared identifier 'pthread_attr_init'
    int r = pthread_attr_init(&handlerThreadAttr);
            ^
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:767:5: error: unknown type name 'pthread_t'; did you mean 'thread_t'?
    pthread_t handlerThread;
    ^~~~~~~~~
    thread_t
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/mach/mach_types.h:122:22: note: 'thread_t' declared here
typedef mach_port_t             thread_t;
                                ^
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:768:9: error: use of undeclared identifier 'pthread_create'
    r = pthread_create(&handlerThread, &handlerThreadAttr, MachExceptionHandlerThread, nullptr);
        ^
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:772:9: error: use of undeclared identifier 'pthread_detach'
    r = pthread_detach(&handlerThread);
        ^
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:784:19: error: redefinition of 'kret'
    kern_return_t kret = thread_set_exception_ports(thisThread,
                  ^
/Users/pepyakin/dev/etc/wasmtime/lib/execute/signalhandlers/SignalHandlers.cpp:753:19: note: previous definition is here
    kern_return_t kret;
                  ^
8 errors generated.
make[2]: *** [CMakeFiles/SignalHandlers.dir/SignalHandlers.cpp.o] Error 1
make[1]: *** [CMakeFiles/SignalHandlers.dir/all] Error 2
make: *** [all] Error 2
thread 'main' panicked at '
command did not execute successfully, got: exit code: 2

build script failed, must exit now', /Users/pepyakin/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/cmake-0.1.35/src/lib.rs:778:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed
@sunfishcode
Copy link
Member

These issues are now fixed on trunk, and we also now have osx enabled on Travis.

@pepyakin
Copy link
Contributor Author

Can confirm that!

pchickey pushed a commit that referenced this issue May 27, 2021
docs: in new-api, trap handlers are installed at Engine creation
grishasobol pushed a commit to grishasobol/wasmtime that referenced this issue Nov 29, 2021
* Extract test.sh and doc.sh from .travis.yml

* check.sh
howjmay pushed a commit to howjmay/wasmtime that referenced this issue Jan 24, 2022
pchickey pushed a commit to pchickey/wasmtime that referenced this issue May 12, 2023
…ce#30)

This required fleshing out the `wasi-clocks` host implementation a bit and
adding a `read_vectored_at` implementation for `ReadPipe`.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
pchickey pushed a commit to pchickey/wasmtime that referenced this issue May 16, 2023
…ce#30)

This required fleshing out the `wasi-clocks` host implementation a bit and
adding a `read_vectored_at` implementation for `ReadPipe`.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dhil added a commit to dhil/wasmtime that referenced this issue Oct 30, 2023
mooori pushed a commit to mooori/wasmtime that referenced this issue Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants