Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CI test-runner job for aarch64-macos (M1 Mac) #4177

Closed
cfallin opened this issue May 20, 2022 · 4 comments
Closed

Create CI test-runner job for aarch64-macos (M1 Mac) #4177

cfallin opened this issue May 20, 2022 · 4 comments
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator wasmtime Issues about wasmtime that don't fall into another label

Comments

@cfallin
Copy link
Member

cfallin commented May 20, 2022 •
edited
Loading

We've discussed this in various places (most recently #3982) but we don't seem to have an open issue tracking the eventual addition of an actual CI job for aarch64-macos ("M1" / "Apple Silicon").

It looks like GitHub is perhaps making slow progress toward having runners: see actions/runner#805 where just today, a GitHub PM indicated that next week there will be a pre-release of a self-hosted M1 runner. Now, we likely want to wait until there are GitHub runners, as there are serious security concerns with self-hosted ones; but this is progress.

The relevant issue for GitHub-hosted VM runners seems to be actions/runner-images#2187.
@cfallin cfallin added wasmtime Issues about wasmtime that don't fall into another label cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels May 20, 2022
@cfallin cfallin changed the title Create CI runner job for aarch64-macos (M1 Mac) Create CI test-runner job for aarch64-macos (M1 Mac) May 20, 2022
@cfallin
Copy link
Member Author

cfallin commented May 20, 2022

And for maximal clarity and to give background info: we have a build job that produces M1 binaries (thanks to #3983) but our CI does not run tests on this platform. We have various folks running tests manually, and Embark Studios (thanks to bnjbvr) runs an M1-hosted CI internally with wasmtime. But ideally we'd get tests run on every PR, as for the other platforms we support.

@afonso360
Copy link
Contributor

afonso360 commented Oct 2, 2023 •
edited
Loading

It looks like Github Actions has released M1 Runners as a public beta today (github/roadmap#528)

@cfallin
Copy link
Member Author

cfallin commented Oct 2, 2023

Woah, neat! I'll see if I can switch us over now.

@cfallin cfallin mentioned this issue Oct 2, 2023
Closed
cfallin added a commit to cfallin/wasmtime that referenced this issue Oct 2, 2023
@cfallin
CI: switch to AArch64 macOS runners.
be35ff5 
This should result in faster builds for macOS, and additionally will let
us actually run tests on aarch64-macos now (previously we only had
binary builds).

Fixes bytecodealliance#4177.

prtest:full
@alexcrichton
Copy link
Member

This is now done, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator wasmtime Issues about wasmtime that don't fall into another label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: switch to AArch64 macOS runners. cfallin/wasmtime
3 participants
@alexcrichton @cfallin @afonso360