-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASI: Greater isolation between fd and file functions #67
Comments
Some preliminary thoughts here: The API does use a naming scheme; That said, the capability model doesn't depend on absolute paths at the syscall level, so there's no requirement for a traditional-looking filesystem ( |
I have (not yet public) reasons for wanting these calls in a separate module. See #74 for my preferred approach. |
Ok. FWIW, others have requested we split out the command-line argument and environment variable handling into separate modules too. I think these are reasonable, but it does feel like something we should do once we have a proper forum, such as a CG Subgroup, which we'll hopefully have soon. |
I've requested an invite to the meeting. Hopefully, we'll be collaborating more directly in a short time. |
The modularization PR has now landed, so this will be in the next snapshot! |
…iance#67) * On Windows, ignore access-denied errors from `sync_all`. On Windows `sync_all` does `FlushFileBuffers` which fails with an access-denied error if the file not opened for writing. Ignore this error, for compatibility with POSIX-style APIs. Fixes bytecodealliance#66. * Ignore `ERROR_ACCESS_DENIED` from `sync_data` too. * Temporarily disable directory syncing for now.
In one particular implementation of a WASM runtime (not yet public), we plan to support file descriptors but not a filesystem. It would be great if filesystem related functions could be a separate specification.
It would also generally be good to create a stronger separation between operations which work on file descriptors in general and those which work only on files in a filesystem. The precedent for this already exists in the
__wasi_sock_*()
functions.The text was updated successfully, but these errors were encountered: