Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmtime serve broken in 14.0.0 branch #7396

Closed
tschneidereit opened this issue Oct 29, 2023 · 0 comments · Fixed by #7397
Closed

wasmtime serve broken in 14.0.0 branch #7396

tschneidereit opened this issue Oct 29, 2023 · 0 comments · Fixed by #7397
Labels
bug Incorrect behavior in the current implementation that needs fixing

Comments

@tschneidereit
Copy link
Member

it looks like wasmtime serve was broken by #7395, and only works when setting WASMTIME_NEW_CLI=1. Otherwise, the CLI tries to load a file called serve.

To reproduce, it's not even required to create a test wasm file, just running wasmtime serve whatever should be enough.

CC @alexcrichton
@tschneidereit tschneidereit added the bug Incorrect behavior in the current implementation that needs fixing label Oct 29, 2023
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Oct 29, 2023
@alexcrichton
Fix parsing of new subcommands
5c1f31d 
This commit updates the parsing of the old CLI to understand new
subcommands to ensure that `wasmtime serve foo.wasm` isn't mistakenly
interpreted in the old CLI as executing the module `serve` with the
argument `foo.wasm`.

Closes bytecodealliance#7396
@alexcrichton alexcrichton mentioned this issue Oct 29, 2023
Merged
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Oct 29, 2023
@alexcrichton
Fix parsing of new subcommands
6c6cd1d 
This commit updates the parsing of the old CLI to understand new
subcommands to ensure that `wasmtime serve foo.wasm` isn't mistakenly
interpreted in the old CLI as executing the module `serve` with the
argument `foo.wasm`.

Closes bytecodealliance#7396
alexcrichton added a commit that referenced this issue Oct 30, 2023
@alexcrichton
Fix parsing of new subcommands (#7398)
c57d458 
This commit updates the parsing of the old CLI to understand new
subcommands to ensure that `wasmtime serve foo.wasm` isn't mistakenly
interpreted in the old CLI as executing the module `serve` with the
argument `foo.wasm`.

Closes #7396
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
@alexcrichton
Fix parsing of new subcommands (#7397)
1d46c2d 
This commit updates the parsing of the old CLI to understand new
subcommands to ensure that `wasmtime serve foo.wasm` isn't mistakenly
interpreted in the old CLI as executing the module `serve` with the
argument `foo.wasm`.

Closes #7396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Incorrect behavior in the current implementation that needs fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix parsing of new subcommands alexcrichton/wasmtime
1 participant
@tschneidereit