-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindgen: errors if interface and exported resource have same name #7775
Labels
bug
Incorrect behavior in the current implementation that needs fixing
Comments
jcbhmr
added
the
bug
Incorrect behavior in the current implementation that needs fixing
label
Jan 14, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this issue
Jan 18, 2024
This mirrors how traits for the host are all called `Host` and it avoids name clashes with types that share the name of the interface they are in. I've also added some simple debugging of macro-generated code to get better error messages. Closes bytecodealliance#7775
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this issue
Jan 18, 2024
This mirrors how traits for the host are all called `Host` and it avoids name clashes with types that share the name of the interface they are in. I've also added some simple debugging of macro-generated code to get better error messages. Closes bytecodealliance#7775
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this issue
Jan 18, 2024
This mirrors how traits for the host are all called `Host` and it avoids name clashes with types that share the name of the interface they are in. I've also added some simple debugging of macro-generated code to get better error messages. Closes bytecodealliance#7775
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 18, 2024
This mirrors how traits for the host are all called `Host` and it avoids name clashes with types that share the name of the interface they are in. I've also added some simple debugging of macro-generated code to get better error messages. Closes #7775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for filing a bug report! Please fill out the TODOs below.
Note: if you want to report a security issue, please read our security policy!
Test Case
TODO: upload Wasm file here
no wasm. just rust.
Steps to Reproduce
Expected Results
it to either auto-rename it due to duplication or otherwise scope it so that this collision doesn't happen
Actual Results
Versions and Environment
Wasmtime version or commit: 16.0.0
Operating system: Windows 10 using WSL
Architecture: x86_64
Extra Info
Anything else you'd like to add?
The text was updated successfully, but these errors were encountered: