Code

Windows fprs preservation#1216

Code

Merged

iximeow merged 41 commits intobytecodealliance:masterbytecodealliance/wasmtime:masterfrom iximeow:windows-fprs-preservationiximeow/wasmtime:windows-fprs-preservationCopy head branch name to clipboardApr 10, 2020

+610-76

Commits

Commits on Apr 9, 2020

• initial brush at preserving SIMD registers in Windows fastcall functions

  iximeow

  committed
  4543e23

• remove outdated comment and align CSR space if any SIMD registers are preserved

  iximeow

  committed
  218ff4f

• x86: preserve/restore callee-save xmm registers

  iximeow

  committed
  dd558cb

• rustfmt

  iximeow

  committed
  0537418

• i do not understand why these are being rejected now

  iximeow

  committed
  6147df3

• rcx is used as a return value register, but r11 is free at return

  iximeow

  committed
  ad96c5a

• use rbp instead of r11 to work around missing fstDisp8/fldDisp8 encodings

  iximeow

  committed
  59d23fa

• avoid growing callee-save space when already 16-byte aligned

  iximeow

  committed
  bee0989

• fix merge confict with EBB rename

  iximeow

  committed
  8f33538

• tests are real too

  iximeow

  committed
  eefa4fc

• also record xmm preservation in Windows fastcall unwind info

  iximeow

  committed
  2e632bd

• turns out f64x2 tries to use the nonexistent fstDisp8 encoding for f64x2, so use regular f64 instead

  iximeow

  committed
  3de41fa

• trusty rustfmt

  iximeow

  committed
  aa5d68e

• clarify that Windows only requires the low 128 bits of floating point registers

  iximeow

  committed
  3ce7acf

• fix FPR preservation overlapping with GPR stack area

  iximeow

  committed
  cc99f14

• rustfmt

  iximeow

  committed
  597c994

• specify that ss0 should be a 32-byte spill slot, sufficient for two xmm registers

  iximeow

  committed
  d22ec8a

• almost fix offset calculations kind of sort of

  iximeow

  committed
  9489c05

• maybe it works now

  iximeow

  committed
  cc2975a

• maaaybe get Windows FPR unwind info right?

  iximeow

  committed
  403ebb2

• running rustfmt in the wrong directory does nothing

  iximeow

  committed
  eeca3f4

• ci speak to me of windows woes

  iximeow

  committed
  b86234b

• only check for aligned frame allocation when we need it to be aligned

  iximeow

  committed
  eeea0dd

• print the whole prologue that caused issues in unwind

  Show description for 74d4ab8
  iximeow

  committed
  74d4ab8

• add a comment explaining the seemingly-trunctaed test

  iximeow

  committed
  f0f2394

• Revert "ci speak to me of windows woes"

  Show description for 7bcff83
  iximeow

  committed
  7bcff83

• preserve FPRs in an ExplicitSlot rather than SpillSlot

  Show description for 56e45cf
  iximeow

  committed
  56e45cf

• remove helper function that only existed due to a bad rebase

  iximeow

  committed
  84da124

• temporarily disable the panic-reaching multi-return spectest

  iximeow

  committed
  ceb48bf

• rust ... format ...

  iximeow

  committed
  291d09b

• ignore more windows-unfriendly tests?

  iximeow

  committed
  0a418a2

• try different names for the testsuites?

  iximeow

  committed
  a7e23a9

• rustfmt

  iximeow

  committed
  52425ef

• update panic message with reference to implementation limit

  iximeow

  committed
  3060c8c

• review feedback

  iximeow

  committed
  42d129b

• fix date

  iximeow

  committed
  c7547ed

• try making unwind info fallible

  iximeow

  committed
  c3530e6

• pass errors in generating unwind info back up through CompiledFunctionUnwindInfo::new

  iximeow

  committed
  f403c0a

• forgot to rustfmt

  iximeow

  committed
  750507a

• make emit_fde Result-y as well

  iximeow

  committed
  4e1b10e

Commits on Apr 10, 2020

• Update cranelift/codegen/src/isa/mod.rs

  Show description for 89af7e1
  

  iximeow

  and

  bjorn3

  authored
  89af7e1