Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a --target option to wasm2obj #18

Merged
merged 1 commit into from
Oct 10, 2018
Merged

add a --target option to wasm2obj #18

merged 1 commit into from
Oct 10, 2018

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented Oct 9, 2018

Feedback on this welcome.

sunfishcode
sunfishcode reviewed Oct 9, 2018
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple notes below. Don't worry about the CI failure; that's just rustfmt churn which I've now fixed on master.

src/wasm2obj.rs Show resolved Hide resolved
src/wasm2obj.rs Outdated
wasm2obj --help | --version

Options:
-v, --verbose displays the module and translated functions
-h, --help print this help message
--target <TARGET> build for the target triple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a mention here that the default behavior is to target the host?

@froydnj
Copy link
Contributor Author

froydnj commented Oct 9, 2018

Oh, also, forgot to ask: is it desirable to make a similar change to wasmtime in addition to wasm2obj?

@sunfishcode
Copy link
Member

I don't think so, because wasmtime is just JITing the code into memory and executing it, so the target should match the host.

@froydnj
Copy link
Contributor Author

froydnj commented Oct 10, 2018

Rebased and added note about host compilation.

@sunfishcode
Copy link
Member

Looks good!

@sunfishcode sunfishcode merged commit 5f11f44 into bytecodealliance:master Oct 10, 2018
sunfishcode pushed a commit to sunfishcode/wasmtime that referenced this pull request Oct 2, 2019
@eira-fransham
Merge pull request bytecodealliance#18 from Vurich/microwasm
74d0e41 
Microwasm
kubkon added a commit to kubkon/wasmtime that referenced this pull request Mar 11, 2020
@kubkon
Implement fmt::Display for enums, flags, and ints (bytecodealliance#18)
6780650 
* Implement fmt::Display for enums

`wasi_common` relies on `strerror` to nicely format error messages.
`strerror` is autoimplemented in `wig`. I thought it might be useful
to provide a Rust-idiomatic alternative which boils down to autoimplementing
`fmt::Display` for all enums.

* Implement fmt::Display for flags

* Implement fmt::Display for ints
howjmay pushed a commit to howjmay/wasmtime that referenced this pull request Jan 24, 2022
@liangyuanpeng @alexcrichton
fix readme of wrong NewInstance not enough arguments error (bytecodea…
fd2772b 
…lliance#18)

* fix readme of wrong NewInstance not enough arguments error

* [readme] update go package version to 0.17.0
howjmay pushed a commit to howjmay/wasmtime that referenced this pull request Jan 24, 2022
@c0mm4nd @alexcrichton @liangyuanpeng
lint and fmt code in Go style (bytecodealliance#22)
1b3b541 
* Update to latest wasmtime APIs

* Update CI to latest Go 1.13 and 1.14 releases (bytecodealliance#19)

1.14.3 at least had a change to cgo, maybe we'll get lucky.

Not sure what your thoughts are on how many point releases to cover in CI, so I just bumped 1.13 and 1.14 to the latest.

* fix readme of wrong NewInstance not enough arguments error (bytecodealliance#18)

* fix readme of wrong NewInstance not enough arguments error

* [readme] update go package version to 0.17.0

* lint and fmt code in Go style

- DONE: convert strcut and func docstring to Go style
- DONE: if block ends with a return statement, so drop this else and outdent its block
- DONE: don't use ALL_CAPS in Go names; use CamelCase
- DONE: dont use underscore in names
- DONE: receiver name config should be consistent with previous
- DONE: add comments according to webassembly spec

* fmt

Co-authored-by: Alex Crichton <alex@alexcrichton.com>
Co-authored-by: Alex Vidal <alexvidal@khanacademy.org>
Co-authored-by: lan <liangyuanpengem@163.com>
dhil added a commit to dhil/wasmtime that referenced this pull request Apr 11, 2023
@dhil
Restore compatibility with wasm-tools. (bytecodealliance#18)
2673215 
* Restore compatibility with wasm-tools.

* An auxiliary function to get the arity of a continuation from an index

* Fetch wasmparser and wast dependencies from effect-handlers/wasm-tools#typed-continuations
dhil added a commit to dhil/wasmtime that referenced this pull request Apr 27, 2023
@dhil
Restore compatibility with wasm-tools. (bytecodealliance#18)
6f19436 
* Restore compatibility with wasm-tools.

* An auxiliary function to get the arity of a continuation from an index

* Fetch wasmparser and wast dependencies from effect-handlers/wasm-tools#typed-continuations
pchickey pushed a commit to pchickey/wasmtime that referenced this pull request May 12, 2023
@sunfishcode
Implement path_open. (bytecodealliance#18)
91fff49 
* Implement `path_open`.

* Implement `fd_close`, and finish `path_open`.

* Stub out `close` in the host impl.
dhil added a commit to dhil/wasmtime that referenced this pull request May 16, 2023
@dhil
Restore compatibility with wasm-tools. (bytecodealliance#18)
374e02d 
* Restore compatibility with wasm-tools.

* An auxiliary function to get the arity of a continuation from an index

* Fetch wasmparser and wast dependencies from effect-handlers/wasm-tools#typed-continuations
pchickey pushed a commit to pchickey/wasmtime that referenced this pull request May 16, 2023
@sunfishcode
Implement path_open. (bytecodealliance#18)
abe30a7 
* Implement `path_open`.

* Implement `fd_close`, and finish `path_open`.

* Stub out `close` in the host impl.
dhil added a commit to dhil/wasmtime that referenced this pull request May 19, 2023
@dhil
Restore compatibility with wasm-tools. (bytecodealliance#18)
1a5912b 
* Restore compatibility with wasm-tools.

* An auxiliary function to get the arity of a continuation from an index

* Fetch wasmparser and wast dependencies from effect-handlers/wasm-tools#typed-continuations
dhil added a commit to dhil/wasmtime that referenced this pull request May 23, 2023
@dhil
Restore compatibility with wasm-tools. (bytecodealliance#18)
5809381 
* Restore compatibility with wasm-tools.

* An auxiliary function to get the arity of a continuation from an index

* Fetch wasmparser and wast dependencies from effect-handlers/wasm-tools#typed-continuations
frank-emrich added a commit to frank-emrich/wasmtime that referenced this pull request Sep 30, 2023
@frank-emrich
Remove cont_obj_occupy_next_args_slots libcall (bytecodealliance#18)
b9f9088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froydnj @sunfishcode