Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: Implement Icmp for I16X8 and I32X4 #1826

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

jgouly
Copy link
Contributor

@jgouly jgouly commented Jun 5, 2020

Copyright (c) 2020, Arm Limited.

Probably best to not merge this until #1802 is, since I don't want to cause more trouble for Anton.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Jun 5, 2020
@github-actions
Copy link

github-actions bot commented Jun 5, 2020

Subscribe to Label Action

cc @bnjbvr

This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64"

Thus the following users have been cc'd because of the following labels:

  • bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Perhaps we can remove the TODO regarding returning vs. asserting, but otherwise this looks great!

cranelift/codegen/src/isa/aarch64/lower_inst.rs Outdated Show resolved Hide resolved
@cfallin
Copy link
Member

cfallin commented Jun 9, 2020

Thanks -- force-pushed a merge conflict fix; will merge when green.

Copyright (c) 2020, Arm Limited.
@cfallin cfallin merged commit c30f99d into bytecodealliance:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants