Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the spec::simd::simd_address test for AArch64 #1859

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

akirilov-arm
Copy link
Contributor

This test was previously enabled by PR #1802, which was failing in CI for unclear reasons and was subsequently merged without enabling any tests to unblock further work. However, the same PR enabled another test as well, so now we just isolate spec::simd::simd_address in a small change to check if it is problematic or not.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent -- it looks like our CI system's mild indigestion has gotten better today. Thanks for this!

@cfallin cfallin merged commit 3570363 into bytecodealliance:master Jun 10, 2020
@akirilov-arm
Copy link
Contributor Author

Well, I still have to try spec::simd::simd_align, but I am also glad that this passes.

@akirilov-arm akirilov-arm deleted the simd_address branch June 10, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants