Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install LLDB in CI to fix intermittent failure on Ubuntu 20.04 image. #2740

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Mar 18, 2021

There seems to be an intermittent CI issue, as uncovered by @peterhuene in this comment, affecting a few open PRs right now. This attempts to fix the issue by adding lldb to the setup steps for the debugger tests (alongside our already-existing apt-get install gdb).

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine by me if CI passes. I don't know much about the lldb/gdb setup though, so I'm not sure if this should be a deeper fix or something like that.

@peterhuene
Copy link
Member

I noticed that after my comment yesterday the GitHub actions team updated the virtual environments to note that ubuntu-latest now points at 20.04, so that is what our tests are now being run with always.

@cfallin cfallin merged commit 59dfe4b into bytecodealliance:main Mar 18, 2021
@cfallin cfallin deleted the fix-lldb-ci branch March 18, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants