Support "sleep" forms of poll_oneoff.
#2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for `poll_oneoff` calls which just sleep on a relative timeout. This fixes a bug handling code compiled with WASI libc's `sleep` family of functions, which call `poll_oneoff` with a `CLOCK_REALTIME` timer, which wasn't previously implemented.
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
reviewed
Mar 22, 2021
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This special case is a good idea, but i'd like for the thread::sleep call to instead be dispatched into self.sched.sleep so that wasi-common consumers can control that implementation by either using the default wasi-cap-std-sync impls or creating their own.
There was a problem hiding this comment.
Sounds good; I've now added a sleep function to WasiSched and added impls for it.
pchickey
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
poll_oneoffcalls which just sleep on a relativetimeout. This fixes a bug handling code compiled with WASI libc's
sleepfamily of functions, which call
poll_oneoffwith aCLOCK_REALTIMEtimer, which wasn't previously implemented.