wiggle: delete GuestErrorConversion, improve some error reporting #2760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest renovation to witx, wiggle no longer generates code that calls the
GuestErrorConversion
trait to transform aGuestError
into the function's error type. Instead, wiggle will trap execution if aGuestError
is thrown in generated code.This PR removes generation of the
GuestErrorConversion
trait. Users can delete their impls of it - they are dead code.I also fixed up the Display impl of the
GuestError::InFunc
variant to be more useful, and deletedGuestError::InDataField
because it was also dead code.