Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiggle: delete GuestErrorConversion, improve some error reporting #2760

Merged
merged 7 commits into from
Mar 24, 2021

Conversation

pchickey
Copy link
Contributor

With the latest renovation to witx, wiggle no longer generates code that calls the GuestErrorConversion trait to transform a GuestError into the function's error type. Instead, wiggle will trap execution if a GuestError is thrown in generated code.

This PR removes generation of the GuestErrorConversion trait. Users can delete their impls of it - they are dead code.

I also fixed up the Display impl of the GuestError::InFunc variant to be more useful, and deleted GuestError::InDataField because it was also dead code.

@pchickey pchickey requested a review from alexcrichton March 24, 2021 05:23
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Mar 24, 2021
@github-actions
Copy link

Subscribe to Label Action

cc @kubkon

This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@pchickey pchickey merged commit db7ec95 into main Mar 24, 2021
@pchickey pchickey deleted the pch/wiggle_error_reporting branch March 24, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants