Better Wasmtime API for embedder #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
force-pushed
the
wasmtime-api
branch
from
05624b0
to
a137d02
Compare
|
LGTM! |
sunfishcode
pushed a commit
that referenced
this pull request
Aug 21, 2019
* Migrate wasm-rust-api code to wasmtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address:
There is the work happening to create wasm-c-api. The prototyping in happening in C++, though the goal is to make it in C. This PR translates existing C++ classes into Rust, and provides simple C stubs to be used from C code (see "c-examples" folder)
As example, there is "example/gcd.rs" that shows how to use the Rust API. The wasmtime was updated as well to use this API. This PR implements basic functionality needed to run the wasmtime, and requires future work (e.g. trap, tables, etc).