-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable copy-on-write heap initialization by default #3825
Enable copy-on-write heap initialization by default #3825
Conversation
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A random thought occurs: now that this feature has been generalized to work with generic Unix and mmap files straight from disk, with no actual memfd_create()
, I wonder if there's a better name for it, like "copy-on-write heap images"? (cow_heaps
?) To be clear I don't think it absolutely needs to change; it's well-documented exactly what it means in any case; but it might avoid some confusion at the margins in the future if it doesn't refer to the Linux-specific feature.
crates/wasmtime/src/config.rs
Outdated
/// | ||
/// This feature of Wasmtime is also platform-specific: | ||
/// | ||
/// * Unix - this feature is only supported when loading modules from a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can put "Unix" after "Linux" in this list and say "Other Unix" instead, for clarity?
3f56e9d
to
617c9cc
Compare
Seems reasonable to me! I've switched the config option to |
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "fuzzing"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
617c9cc
to
4057ae1
Compare
I went ahead and merged #3831 because I read that first and rebased here to update the names/docs w.r.t. "memfd" terminology |
This commit enables the `Config::memfd` feature by default now that it's been fuzzed for a few weeks on oss-fuzz, and will continue to be fuzzed leading up to the next release of Wasmtime in early March. The documentation of the `Config` option has been updated as well as adding a CLI flag to disable the feature.
Switch instead to forms of "memory image" or "cow" or some combination thereof.
4057ae1
to
c4d5816
Compare
…#3825) * Enable copy-on-write heap initialization by default This commit enables the `Config::memfd` feature by default now that it's been fuzzed for a few weeks on oss-fuzz, and will continue to be fuzzed leading up to the next release of Wasmtime in early March. The documentation of the `Config` option has been updated as well as adding a CLI flag to disable the feature. * Remove ubiquitous "memfd" terminology Switch instead to forms of "memory image" or "cow" or some combination thereof. * Update new option names
This commit enables the
Config::memfd
feature by default now that it'sbeen fuzzed for a few weeks on oss-fuzz, and will continue to be fuzzed
leading up to the next release of Wasmtime in early March. The
documentation of the
Config
option has been updated as well as addinga CLI flag to disable the feature.