Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Wasmtime 0.35.0 #3885

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Release Wasmtime 0.35.0 #3885

merged 1 commit into from
Mar 7, 2022

Conversation

wasmtime-publish
Copy link
Collaborator

This is an automated pull request from CI which is intended to
notify maintainers that it's time to release Wasmtime version
0.35.0. Version numbers have been bumped
in this PR automatically and the release process will automatically
enter the next stages once this PR is merged.

It's recommended that maintainers double-check that RELEASES.md
is up-to-date. If not please feel free to push to this PR any
modifications to the release notes. Additionally before merging it's
probably best to double-check the release process and make sure that
everything is ship-shape.

[automatically-tag-and-release-this-commit]
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. cranelift:module cranelift:wasm isle Related to the ISLE domain-specific language labels Mar 5, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:module", "cranelift:wasm", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@bjorn3
Copy link
Contributor

bjorn3 commented Mar 5, 2022

No regressions on cg_clif's side. Just needs a small patch to adapt for an api change:

diff --git a/src/lib.rs b/src/lib.rs
index cb18f42f..21939cde 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -301,7 +301,10 @@ fn build_isa(sess: &Session, backend_config: &BackendConfig) -> Box<dyn isa::Tar
         }
     };
 
-    isa_builder.finish(flags)
+    match isa_builder.finish(flags) {
+        Ok(target_isa) => target_isa,
+        Err(err) => sess.fatal(&format!("failed to build TargetIsa: {}", err)),
+    }
 }
 
 /// This is the entrypoint for a hot plugged rustc_codegen_cranelift

@alexcrichton
Copy link
Member

I've put the release notes at #3891 for review, and otherwise unless there's any objection I'll merge this later today.

@cfallin
Copy link
Member

cfallin commented Mar 7, 2022

Good to release from my point of view!

@alexcrichton alexcrichton merged commit 9137b4a into main Mar 7, 2022
@alexcrichton alexcrichton deleted the ci/bump-version branch March 7, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:meta Everything related to the meta-language. cranelift:module cranelift:wasm cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants