Make WasiCtx overridable
#3895
Merged
Make WasiCtx overridable
#3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
approved these changes
Mar 7, 2022
|
@pchickey Any chance this can land in tomorrow's release? We'd hate to lose a month on this. |
|
If @alexcrichton is ok holding up the release I am happy to get this in |
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
Sorry, didn't account for case with multiple bounds (when |
rvolosatovs
force-pushed
the
feature/generic-wasi-ctx
branch
from
73d0442 to
3ac1581
Compare
rvolosatovs
commented
Mar 7, 2022
pchickey
approved these changes
Mar 7, 2022
rvolosatovs
force-pushed
the
feature/generic-wasi-ctx
branch
from
3ac1581 to
ea5ebee
Compare
In some use cases it is desirable to provide a custom snapshot WASI context. Facilitate this by depending on a combination of traits required rather than concrete type in the signature. Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
feature/generic-wasi-ctx
branch
from
ea5ebee to
adf702c
Compare
|
Should this be added to the 0.35.0 release notes? |
|
Sure if you'd like to send a PR I can take a look. |
jeffparsons
added a commit
to jeffparsons/wasmtime
that referenced
this pull request
Mar 13, 2022
This is a follow-up to bytecodealliance#3895, which landed after the release notes were written.
alexcrichton
pushed a commit
that referenced
this pull request
Mar 14, 2022
This is a follow-up to #3895, which landed after the release notes were written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some use cases it is desirable to provide a custom snapshot WASI
context. Facilitate this by depending on a combination of traits
required rather than concrete type in the signature.
This change allows for e.g. wrapping
WasiCtxinto a struct and providing custom implementations for traits