Cherrypick and release-notes update for 0.35.1. #3909
Conversation
In bytecodealliance#3849, I moved uextend over to ISLE in the x64 backend. Unfortunately, the lowering patterns had a bug in the i32-to-i64 special case (when we know the generating instruction zeroes the upper 32 bits): it wasn't actually special casing for an i32 source! This meant that e.g. zero extends of the results of i8 adds did not work properly. This PR fixes the bug and updates the runtest for extends significantly to cover the narrow-value cases. No security impact to Wasm as Wasm does not use narrow integer types. Thanks @bjorn3 for reporting!
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle", "wasmtime:docs"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
Hmm, so the option to merge this with two separate commits (the cherrypick of the earlier PR, and then the release-notes update) is disabled because the repository now only allows "Squash and Merge". This is probably not the right solution for merges into release branches that are actually carrying multiple logically separate changes around; if I had to cherrypick multiple PRs into the point release then it would seem wrong to squash them together; cc @tschneidereit to think more about this / perhaps see if we can have the restriction only on In any case, for forward progress, I'll go ahead and merge this. |
Creating a patch release to cherrypick the fix from #3906 for Cranelift.