cranelift: Use round_ties_even for nearest in interpreter
#4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @MaxGraey pointed out (thanks!) in bytecodealliance#4397, `round` has different behavior from `nearest`. And it looks like the native rust implementation is still pending stabilization. Right now we duplicate the wasmtime implementation, merged in bytecodealliance#2171. However, we definitely should switch to the rust native version when it is available.
github-actions
bot
added
the
cranelift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @MaxGraey pointed out (thanks!) in #4397,
roundhas different behavior fromnearest. And it looks like the native rust implementation is still pending stabilization.Right now we duplicate the wasmtime implementation, merged in #2171 since its quite short.
This also adds the missing tests that would have caught this issue.
Note: I'm happy to replace this with a version that tries to reuse the wasmtime implementation, but it wasn't immediately obvious to me how to do that in a clean manner.