cranelift: Fix shifts and implement rotates in interpreter #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
jameysharp
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
I don't feel qualified to review the x64 ISLE rules here, so I think @cfallin (or perhaps @abrown or @elliottt?) should glance at this. That said, the new tests look comprehensive to me, and they pass in CI, which gives me good confidence that the lowering changes are correct. The interpreter implementation also looks plausible.
Unfortunately we've changed CI configuration since you opened this PR, so you'll need to rebase to get the new CI actions to run before we can merge this.
|
|
||
|
|
||
| ;; This is a regression test for rotates on x64 | ||
| ;; See: https://github.com/bytecodealliance/wasmtime/pull/3610 |
There was a problem hiding this comment.
I really appreciate that you not only tracked down where these particular tests came from, but also left a link here in case anybody else wonders!
afonso360
force-pushed
the
interp-shifts
branch
from
afb00aa to
32cda80
Compare
cfallin
approved these changes
Aug 11, 2022
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Aug 11, 2022
These were moved to the main shifts file in bytecodealliance#4519 but this file was accidentaly left in tree. It also fixes the missing sshr_i8_i8 testcase
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Aug 11, 2022
These were moved to the main shifts file in bytecodealliance#4519 but this file was accidentaly left in tree. It also fixes the missing sshr_i8_i8 testcase
jameysharp
pushed a commit
that referenced
this pull request
Aug 12, 2022
* cranelift: Remove shifts-small-types runtests These were moved to the main shifts file in #4519 but this file was accidentaly left in tree. It also fixes the missing sshr_i8_i8 testcase * cranelift: Add shifts to fuzzer * cranelift: Add extends to fuzzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR fixes some issues with shifts in the interpreter and implements rotates.
It also fixes some issues with the x64 implementation where some type combinations for
rotl/rotrwere not lowered.cc: @jameysharp @cfallin