New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: Print error message when basic blocks are invalid #4591

Merged

jameysharp merged 1 commit into bytecodealliance:main from afonso360:frontend-print-err-msg

Aug 9, 2022

Contributor

afonso360 commented Aug 3, 2022

👋 Hey,

This PR changes the frontend to print not only the instruction that causes the block to be invalid, but what the actual issue is.

When working on the fuzzer this is helpful to pinpoint issues.

cc: @jameysharp


          cranelift: Print error message when basic blocks are invalid

1d28405

github-actions bot added the cranelift label

jameysharp approved these changes

View reviewed changes

Contributor

jameysharp left a comment

It's always nice to actually use diagnostic information that's already available. 😆

jameysharp merged commit a36a52a into bytecodealliance:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels