Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Fmla and Bsl out into new VecRRRMod op #4638

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

dheaton-arm
Copy link
Contributor

Separates the following opcodes for AArch64 into a separate VecALUModOp enum,
which is emitted via the VecRRRMod instruction. This separates vector ALU
instructions which modify a register from instructions which write to a new register:

  • Bsl
  • Fmla

Addresses a discussion in #4608.

Copyright (c) 2022 Arm Limited

Separates the following opcodes for AArch64 into a separate `VecALUModOp` enum,
which is emitted via the `VecRRRMod` instruction. This separates vector ALU
instructions which modify a register from instructions which write to a new register:
- `Bsl`
- `Fmla`

Addresses [a discussion](bytecodealliance#4608 (comment)) in bytecodealliance#4608.

Copyright (c) 2022 Arm Limited
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Aug 8, 2022
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin cfallin merged commit 47a67d7 into bytecodealliance:main Aug 8, 2022
@dheaton-arm dheaton-arm deleted the isle-vecalumodop branch August 9, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants