Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: Upgrade libm to 0.2.4 #4670

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

afonso360
Copy link
Contributor

@afonso360 afonso360 commented Aug 10, 2022

This resolves an issue with incorrect fmaf on the x86_64-pc-windows-gnu target under some inputs.

This was fixed in rust-lang/libm#267

See: #4517

This resolves an issue with incorrect fmaf on the x86_64-pc-windows-gnu target under some inputs.

See: bytecodealliance#4517
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Aug 10, 2022
@afonso360
Copy link
Contributor Author

It looks like this fails (expectedly) in cargo-vet.

However, it is my understanding that only Bytecode Alliance members can modify this / approve new deps. I think this was mentioned in one of the cranelift meetings, but can't find the exact policy in the repository.

@alexcrichton is this the case?

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If you add this diff to this PR that should appease cargo vet:

diff --git a/supply-chain/audits.toml b/supply-chain/audits.toml
index 9a4b9bd23..c172585c1 100644
--- a/supply-chain/audits.toml
+++ b/supply-chain/audits.toml
@@ -19,6 +19,16 @@ criteria = "safe-to-deploy"
 version = "1.0.0"
 notes = "I am the author of this crate."

+[[audits.libm]]
+who = "Alex Crichton <alex@alexcrichton.com>"
+criteria = "safe-to-deploy"
+delta = "0.2.2 -> 0.2.4"
+notes = """
+This diff primarily fixes a few issues with the `fma`-related functions,
+but also contains some other minor fixes as well. Everything looks A-OK and
+as expected.
+"""
+
 [[audits.regalloc2]]
 who = "Jamey Sharp <jsharp@fastly.com>"
 criteria = "safe-to-deploy"

@alexcrichton alexcrichton enabled auto-merge (squash) August 10, 2022 15:03
@alexcrichton alexcrichton merged commit 30e2a9b into bytecodealliance:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants