Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: Fuzz icmp and fcmp #4713

Merged
merged 3 commits into from
Aug 15, 2022
Merged

cranelift: Fuzz icmp and fcmp #4713

merged 3 commits into from
Aug 15, 2022

Conversation

afonso360
Copy link
Contributor

👋 Hey,

This PR adds icmp and fcmp to the fuzzer ops list.

cc: @jameysharp

@afonso360 afonso360 marked this pull request as draft August 15, 2022 21:12
@afonso360 afonso360 marked this pull request as ready for review August 15, 2022 21:46
jameysharp
jameysharp approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the all() methods are a nice clean-up for existing code, too.

@jameysharp jameysharp enabled auto-merge (squash) August 15, 2022 23:07
@jameysharp jameysharp merged commit 0f94493 into bytecodealliance:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameysharp jameysharp jameysharp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afonso360 @jameysharp