Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Fcopysign..FcvtToSintSat to ISLE (AArch64) #4753

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Port Fcopysign..FcvtToSintSat to ISLE (AArch64) #4753

merged 2 commits into from
Aug 24, 2022

Conversation

dheaton-arm
Copy link
Contributor

Ported the existing implementations of the following opcodes to ISLE on
AArch64:

  • Fcopysign
    • Also introduced missing support for fcopysign on vector values, as
      per the docs.
    • This introduces the vector encoding for the SLI machine
      instruction.
  • FcvtToUint
  • FcvtToSint
  • FcvtFromUint
  • FcvtFromSint
  • FcvtToUintSat
  • FcvtToSintSat

Copyright (c) 2022 Arm Limited

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Aug 23, 2022
@dheaton-arm dheaton-arm changed the title Port FcvtToUint..`FcvtToSintSat to ISLE (AArch64) Port Fcopysign..`FcvtToSintSat to ISLE (AArch64) Aug 23, 2022
@dheaton-arm dheaton-arm changed the title Port Fcopysign..`FcvtToSintSat to ISLE (AArch64) Port Fcopysign..FcvtToSintSat to ISLE (AArch64) Aug 23, 2022
cfallin
cfallin reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have some thoughts below on a possible refactor but if it's too onerous, we can skip (the side-effecting emits are in inst.isle alongside other emitter-helpers so it's not strictly necessary to fix I think).

cranelift/codegen/src/isa/aarch64/inst.isle Show resolved Hide resolved
cranelift/codegen/src/isa/aarch64/inst.isle Outdated Show resolved Hide resolved
@dheaton-arm
Port Fcopysign..`FcvtToSintSat to ISLE (AArch64)
693e22c 
Ported the existing implementations of the following opcodes to ISLE on
AArch64:
- `Fcopysign`
  - Also introduced missing support for `fcopysign` on vector values, as
    per the docs.
  - This introduces the vector encoding for the `SLI` machine
    instruction.
- `FcvtToUint`
- `FcvtToSint`
- `FcvtFromUint`
- `FcvtFromSint`
- `FcvtToUintSat`
- `FcvtToSintSat`

Copyright (c) 2022 Arm Limited
@dheaton-arm
Document helpers and abstract conversion checks
74fee50
cfallin
cfallin approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin cfallin merged commit 94bcbe8 into bytecodealliance:main Aug 24, 2022
@dheaton-arm dheaton-arm deleted the isle-fpcvt branch August 25, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dheaton-arm @cfallin