Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuzz] Simplify macros used by single-instruction generator #4774

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Aug 24, 2022

This removes the multiple macros used previously to describe the
WebAssembly instruction signatures and replaces them with a single
one--inst!.

This removes the multiple macros used previously to describe the
WebAssembly instruction signatures and replaces them with a single
one--`inst!`.
@abrown abrown requested a review from jameysharp August 24, 2022 18:21
@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Aug 24, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! I have one small suggestion but it's not critical.

crates/fuzzing/src/generators/single_inst_module.rs Outdated Show resolved Hide resolved
@jameysharp
Copy link
Contributor

Looks great to me!

@abrown abrown enabled auto-merge (squash) August 24, 2022 19:53
@abrown abrown merged commit b4c25ef into bytecodealliance:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Issues related to our fuzzing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants