Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x64: Lower tlsvalue, sqmul_round_sat, and uunarrow in ISLE #4793

Merged
merged 5 commits into from
Aug 26, 2022
Merged

x64: Lower tlsvalue, sqmul_round_sat, and uunarrow in ISLE #4793

merged 5 commits into from
Aug 26, 2022

Conversation

elliottt
Copy link
Member

Lower tlsvalue, sqmul_round_sat, and uunarrow in ISLE.

@elliottt elliottt marked this pull request as ready for review August 26, 2022 22:39
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:x64 Issues related to x64 codegen isle Related to the ISLE domain-specific language labels Aug 26, 2022
cfallin
cfallin approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the Uunarrow handwritten code removed, which we just discussed :-)

Thanks for the substantial work in moving all the ISLE lowerings over on x64, and finding/fixing issues along the way -- I'm super-happy to see the last ones gone here!

@github-actions
Copy link

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@elliottt elliottt force-pushed the trevor/x64-tlsvalue branch 2 times, most recently from d075f40 to f04cca3 Compare August 26, 2022 22:48
@elliottt elliottt merged commit 25d960f into bytecodealliance:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliottt @cfallin