Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x64: Lower nop in ISLE #4809

Merged
merged 1 commit into from
Aug 30, 2022
Merged

x64: Lower nop in ISLE #4809

merged 1 commit into from
Aug 30, 2022

Conversation

elliottt
Copy link
Member

@elliottt elliottt commented Aug 29, 2022 •
edited
Loading

Lower nop in ISLE in the x64 backend, and remove the final Ok(()) from the lower function to assert that all cases that aren't handled in ISLE will panic.

@elliottt elliottt force-pushed the trevor/move-nop-to-isle branch from d1ada21 to 32251b6 Compare August 29, 2022 23:59
@elliottt elliottt marked this pull request as ready for review August 29, 2022 23:59
cfallin
cfallin approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Aug 30, 2022
@elliottt elliottt force-pushed the trevor/move-nop-to-isle branch from 32251b6 to 5abab68 Compare August 30, 2022 05:22
@elliottt elliottt merged commit b033aba into bytecodealliance:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliottt @cfallin