Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port fcmp to ISLE (AArch64) #4819

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Port fcmp to ISLE (AArch64) #4819

merged 1 commit into from
Aug 30, 2022

Conversation

dheaton-arm
Copy link
Contributor

Ported the existing implementation of fcmp for AArch64 to ISLE.

This also ports the lower_vector_comparison method to ISLE.

Copyright (c) 2022 Arm Limited

@dheaton-arm
Port fcmp to ISLE (AArch64)
15a51cc 
Ported the existing implementation of `fcmp` for AArch64 to ISLE.

This also ports the `lower_vector_comparison` method to ISLE.

Copyright (c) 2022 Arm Limited
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. labels Aug 30, 2022
cfallin
cfallin approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM overall. A few questions below but nothing that blocks merging this I think.

cranelift/filetests/filetests/isa/aarch64/simd-logical-compile.clif Show resolved Hide resolved
cranelift/filetests/filetests/runtests/simd-conversion.clif Show resolved Hide resolved
@cfallin cfallin merged commit 3d9d759 into bytecodealliance:main Aug 30, 2022
@dheaton-arm dheaton-arm deleted the isle-fcmp branch August 30, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirilov-arm akirilov-arm akirilov-arm left review comments

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dheaton-arm @cfallin @akirilov-arm